Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antora-ui-default: 0-unstable-2024-09-20 -> 0-unstable-2024-12-26 #368384

Conversation

trueNAHO
Copy link
Member

NAHO (2):
  antora-ui-default: use correct version naming convention
  antora-ui-default: 0-unstable-2024-09-20 -> 0-unstable-2024-12-26

 pkgs/by-name/an/antora-ui-default/package.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

I have successfully tested this patchset on my documentation that relies on this package.

Cc: @ehllie

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trueNAHO
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368384


x86_64-linux

✅ 1 package built:
  • antora-ui-default

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 26, 2024
@pbsds pbsds merged commit e695d85 into NixOS:master Dec 31, 2024
43 of 44 checks passed
@trueNAHO
Copy link
Member Author

Thanks for merging this. However, I just realized that I somehow forgot to update the hash, causing the package to implicitly still point to the previous version. I have updated the hash in #369703 and successfully tested everything again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants